
Failure
- What happens if this runs twice? Retries, double clicks and duplicate messages all cause it. Payments and emails are where it hurts.
- What happens when the dependency is slow, not down? Slow is harder than down. Ask where the timeout is.
- What does the user see when it fails? If nobody knows, the design is not finished.
Data
- Where is the source of truth, and what happens when the copies disagree?
- What happens to the rows that already exist? New designs are drawn for new data. Old data ships too.
- How large can this get? A list that grows without a limit is a future incident.
Running it
- How will we know it is broken? Name the log line, the metric or the alert.
- Who gets paged, and what do they do first?
Change
- What is the smallest version we could ship first?
- How do we turn it off? A flag or a rollback path, decided before launch.
Ask without stalling the review
- Ask about behavior, not taste. Taste belongs in a comment on the document.
- Point at the code: "The current consumer has no retry. Does the new design add one, and where?"
- One question at a time, and let the author finish.
- If it cannot be answered in two minutes, write it down as an open question with an owner and move on.